Skip to content

Added: GZip compression feature (#621) #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2019
Merged

Added: GZip compression feature (#621) #623

merged 1 commit into from
Jul 22, 2019

Conversation

@Ant-hem
Copy link
Member

@Ant-hem Ant-hem commented Jul 2, 2019

Q A
Bug fix? no
New feature? yes
BC breaks? no
Related Issue Fix #621
Need Doc update yes

@Ant-hem Ant-hem requested a review from aseure as a code owner July 2, 2019 09:28
aseure
aseure reviewed Jul 5, 2019
View reviewed changes
Copy link

@aseure aseure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we had the discussion just after this PR but could we change this implementation for the enum version of it? Not a GzipEnabled boolean but rather a Compression.{None,GZIP} enum-like one?

@Ant-hem
Copy link
Member Author

Ant-hem commented Jul 5, 2019

Perhaps we had the discussion just after this PR but could we change this implementation for the enum version of it? Not a GzipEnabled boolean but rather a Compression.{None,GZIP} enum-like one?

Yes definitely! I did it for Java, will do for C# now :) This proposition was the first draft.

@Ant-hem
Copy link
Member Author

Ant-hem commented Jul 8, 2019 •
edited
Loading

@aseure updated with e5237a4.

@Ant-hem Ant-hem force-pushed the feat/gzip branch 2 times, most recently from e5237a4 to 55494d8 Compare July 9, 2019 08:19
@Ant-hem
Copy link
Member Author

Ant-hem commented Jul 9, 2019 •
edited
Loading

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

aseure
aseure suggested changes Jul 17, 2019
View reviewed changes
src/Algolia.Search/Clients/SearchConfig.cs Outdated

DefaultHosts = hosts;

Compression = CompressionType.GZIP;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's the default value, don't we want to change it for NONE?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Just updated it.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Ant-hem Ant-hem merged commit 42ab184 into master Jul 22, 2019
@Ant-hem Ant-hem deleted the feat/gzip branch July 22, 2019 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@aseure aseure aseure approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

API feature Do not merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

API Feature - Implement GZIP for POST/PUT

3 participants

@Ant-hem @aseure